fix(annotation): Address regression from #24694 #24874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
commented
Aug 2, 2023
| @@ -93,7 +93,6 @@ describe('AnnotationLayer type guards', () => { | |||
| }, | |||
| ]; | |||
| const recordAnnotationResult: RecordAnnotationResult = { | |||
| columns: ['col1', 'col2'], | |||
There was a problem hiding this comment.
LOL. The columns here should be the same columns as the records which is the output of the conversion of a Pandas DataFrame to a dictionary, i.e., this should have read,
columns: ['a', 'b']
john-bodley
added
the
v3.0
john-bodley
force-pushed
the
john-bodley--fix-24694
branch
from
8845aba
to
8e0ed3b
Compare
Codecov Report
@@ Coverage Diff @@
## master #24874 +/- ##
==========================================
- Coverage 69.00% 69.00% -0.01%
==========================================
Files 1904 1906 +2
Lines 74107 74141 +34
Branches 8194 8208 +14
==========================================
+ Hits 51140 51161 +21
- Misses 20848 20859 +11
- Partials 2119 2121 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
justinpark
approved these changes
Aug 2, 2023
michael-s-molina
pushed a commit
that referenced
this pull request
Aug 4, 2023
mistercrunch
added
🍒 3.0.0
🍒 3.0.1
🍒 3.0.2
🍒 3.0.3
🍒 3.0.4
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR fixes a regression introduced in #24694. Specifically previously the legacy
TableVizreturned both the records and the columns associated with the records, however per here the new formulation only returned the records resulting in the annotation layer being deemed invalid by the frontend.Rather than also explicitly including the column names (which is also redundant as the names are included in the records) this PR simply removes them as they're superfluous and not used by the frontend anywhere.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
CI and ran an end-to-end test locally.
ADDITIONAL INFORMATION