fix(explore): invalid "No Filter" applied #24876
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When a legacy chart converted to the echart, there's a chance that non time range filter has been added in the adhoc_filters. This
No Filter
value has been introduced from https://github.com/apache/superset/pull/24405/files which always addsNo Filter
any given filter types. This commit adds the condition thatNo Filter
added only forTEMPORAL_RANGE
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
No filter
ignoredBefore:
![Screenshot_2023-08-01_at_3_35_44_PM](https://private-user-images.githubusercontent.com/1392866/257955459-83a36888-731c-4cf2-8c14-7c54f26fa95a.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzg4NzIxOTEsIm5iZiI6MTczODg3MTg5MSwicGF0aCI6Ii8xMzkyODY2LzI1Nzk1NTQ1OS04M2EzNjg4OC03MzFjLTRjZjItOGMxNC03YzU0ZjI2ZmE5NWEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIwNiUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMDZUMTk1ODExWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9YWRjMzFmMTAyYjlkZjEyNmU0MmYwNjA3MTliYzIyYmM0OWRiMWU1ODY0ZTg1MTM3Njc5ZmJkYmJkZTBiZTZlNCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.cpmcbuXmEYFQzxlJPIzQXxxxstqY7lgOJRHxU4L04B4)
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION