-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(explore): invalid "No Filter" applied #24876
fix(explore): invalid "No Filter" applied #24876
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24876 +/- ##
=======================================
Coverage 68.99% 69.00%
=======================================
Files 1903 1906 +3
Lines 74072 74141 +69
Branches 8193 8209 +16
=======================================
+ Hits 51107 51161 +54
- Misses 20844 20859 +15
Partials 2121 2121
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(cherry picked from commit 371bffb)
SUMMARY
When a legacy chart converted to the echart, there's a chance that non time range filter has been added in the adhoc_filters. This
No Filter
value has been introduced from https://github.com/apache/superset/pull/24405/files which always addsNo Filter
any given filter types. This commit adds the condition thatNo Filter
added only forTEMPORAL_RANGE
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
No filter
ignoredBefore:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION