Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve SQLite DB engine spec #24909

Merged
merged 4 commits into from
Aug 7, 2023

Fix test

3b8d078
Select commit
Loading
Failed to load commit list.
Merged

feat: improve SQLite DB engine spec #24909

Fix test
3b8d078
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Aug 7, 2023 in 0s

69.00% (+0.00%) compared to 3b81538

View this Pull Request on Codecov

69.00% (+0.00%) compared to 3b81538

Details

Codecov Report

Merging #24909 (3b8d078) into master (3b81538) will increase coverage by 0.00%.
The diff coverage is 88.23%.

@@           Coverage Diff           @@
##           master   #24909   +/-   ##
=======================================
  Coverage   68.99%   69.00%           
=======================================
  Files        1906     1906           
  Lines       74122    74134   +12     
  Branches     8208     8208           
=======================================
+ Hits        51140    51153   +13     
+ Misses      20859    20858    -1     
  Partials     2123     2123           
Files Changed Coverage Δ
superset/db_engine_specs/shillelagh.py 87.50% <71.42%> (-12.50%) ⬇️
superset/db_engine_specs/gsheets.py 76.47% <100.00%> (-0.18%) ⬇️
superset/db_engine_specs/sqlite.py 97.22% <100.00%> (+0.55%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more