Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Tooltip of area chart shows undefined total #24916

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Fixes a bug where the tooltip of the area chart displays undefined totals.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screenshot 2023-08-08 at 11 38 30 Screenshot 2023-08-08 at 11 37 16

TESTING INSTRUCTIONS

Make sure the total are correctly calculated.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #24916 (35faf20) into master (85a7d5c) will decrease coverage by 0.01%.
Report is 1 commits behind head on master.
The diff coverage is 0.00%.

❗ Current head 35faf20 differs from pull request most recent head 34308fe. Consider uploading reports for the commit 34308fe to get more accurate results

@@            Coverage Diff             @@
##           master   #24916      +/-   ##
==========================================
- Coverage   69.00%   68.99%   -0.01%     
==========================================
  Files        1906     1906              
  Lines       74134    74135       +1     
  Branches     8208     8208              
==========================================
  Hits        51153    51153              
- Misses      20858    20859       +1     
  Partials     2123     2123              
Flag Coverage Δ
javascript 55.83% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...tend/plugins/legacy-preset-chart-nvd3/src/utils.js 15.82% <0.00%> (-0.11%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Aug 8, 2023
@michael-s-molina michael-s-molina merged commit ec9e9a4 into apache:master Aug 8, 2023
michael-s-molina added a commit that referenced this pull request Aug 10, 2023
@mistercrunch mistercrunch added 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants