Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fixing Superset typo in docker-compose local installation guide #24920

Merged
merged 2 commits into from
Aug 10, 2023

Conversation

TannerBarcelos
Copy link
Contributor

SUMMARY

Update typo in local Docker installation guide where Superset is misspelled as Sueprset

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before
superset-typo

After
superset-typo-fix

ADDITIONAL INFORMATION

Fixes 24919

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@sfirke
Copy link
Member

sfirke commented Aug 9, 2023

thanks for contributing this PR and catching that! I just recently fixed this typo in the Kubernetes documentation, looks like the same thing got copy-pasted into here also. It has the same typo "telmetry" also.

Could you look at the change I made in https://github.com/apache/superset/pull/24834/files and apply that here to improve the overall quality of the language and fix the telmetry typo? You'd just need to change what appears after To opt-out of this data collection in my PR to be docker-compose specific, not Kubernetes-specific.

@TannerBarcelos
Copy link
Contributor Author

@sfirke sure thing! I can go ahead and do that as well. Thank you for the link to the PR also, I'll reference it.

@sfirke sfirke self-assigned this Aug 10, 2023
@sfirke sfirke self-requested a review August 10, 2023 13:12
Copy link
Member

@sfirke sfirke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sfirke sfirke merged commit 764f0f7 into apache:master Aug 10, 2023
28 checks passed
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: Fix Superset typo in "Installing Locally Using Docker Compose" page
4 participants