Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adds options to show subtotals in Pivot Table #24960

Merged
merged 2 commits into from
Aug 14, 2023
Merged

feat: Adds options to show subtotals in Pivot Table #24960

merged 2 commits into from
Aug 14, 2023

Conversation

michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented Aug 11, 2023 •
edited
Loading

SUMMARY

This PRs enhances the Pivot Table chart with specific controls to display columns and rows subtotals. This will give users more flexibility by allowing a more granular control of which information is displayed in the table.

This feature was discussed in #20234

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2023-08-11.at.11.34.01.mov

TESTING INSTRUCTIONS

Check the video for instructions.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina requested a review from a team as a code owner August 11, 2023 15:39
@michael-s-molina michael-s-molina force-pushed the add-pivot-table-subtotals-controls branch from cf16ea9 to 5ac53e7 Compare August 11, 2023 16:50
kgabryje
kgabryje approved these changes Aug 14, 2023
View reviewed changes
Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-s-molina michael-s-molina merged commit be11556 into apache:master Aug 14, 2023
29 checks passed
@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Aug 14, 2023
michael-s-molina added a commit that referenced this pull request Aug 14, 2023
@michael-s-molina
feat: Adds options to show subtotals in Pivot Table (#24960)
4b07b5d 
(cherry picked from commit be11556)
@michael-s-molina michael-s-molina mentioned this pull request Sep 5, 2023
Closed
6 tasks
@mistercrunch mistercrunch added 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@michael-s-molina
feat: Adds options to show subtotals in Pivot Table (apache#24960)
367894d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgabryje kgabryje kgabryje approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michael-s-molina @kgabryje @mistercrunch