-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Downgrades Prophet to 1.1.1 and Holidays to 0.23 #25017
fix: Downgrades Prophet to 1.1.1 and Holidays to 0.23 #25017
Conversation
For me the combination prophet 1.1.4 and holidays 0.32 is working when installing it inside of a running superset 2.1.0 container. |
Right - no issues for me. At least when installing it inside the already running container. Not sure if this makes any difference though. The pip freeze outputs holidays==0.32 and prophet==1.1.4 as part of the list. Maybe it's worth mentioning that I'm actually running a latest-dev container built with a createdAT timestamp "2023-07-20T12:20:53Z". |
SUMMARY
#24129 bumped Prophet to 1.1.4 but there's a nasty bug affecting all versions following 1.1.1. This PR downgrades Prophet to 1.1.1 and pins the version in
setup.py
. We can relax the version constraint once that bug is fixed.This PR also reverts the holidays bump given that version 0.28 is incompatible with
prophet
1.1.1 even with a declared dependency ofholidays>=0.14.2
. I tried using version 0.28 but it broke CI.TESTING INSTRUCTIONS
CI should be sufficient.
ADDITIONAL INFORMATION