Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Pass the dashboard id when requesting filter values #25025

Merged
merged 2 commits into from
Aug 18, 2023
Merged

chore: Pass the dashboard id when requesting filter values #25025

merged 2 commits into from
Aug 18, 2023

Conversation

michael-s-molina
Copy link
Member

SUMMARY

RBAC logic depends on the dashboard id to determine if a user has access to a resource. This PR adds the dashboard id to filter values requests.

TESTING INSTRUCTIONS

CI should be sufficient.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@pull-request-size pull-request-size bot added size/S and removed size/M labels Aug 18, 2023
john-bodley
john-bodley approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@john-bodley john-bodley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @michael-s-molina

@michael-s-molina michael-s-molina merged commit 52c7186 into apache:master Aug 18, 2023
26 checks passed
@john-bodley john-bodley mentioned this pull request Aug 18, 2023
Merged
9 tasks
@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Aug 18, 2023
michael-s-molina added a commit that referenced this pull request Aug 21, 2023
@michael-s-molina
chore: Pass the dashboard id when requesting filter values (#25025)
88383de 
(cherry picked from commit 52c7186)
@mistercrunch mistercrunch added 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@michael-s-molina
chore: Pass the dashboard id when requesting filter values (apache#25025
f61d4e8 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@john-bodley john-bodley john-bodley approved these changes

@justinpark justinpark Awaiting requested review from justinpark

@kgabryje kgabryje Awaiting requested review from kgabryje

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michael-s-molina @john-bodley @mistercrunch