Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Dashboard fullscreen is removing custom URL params #25028

Merged
merged 1 commit into from
Aug 18, 2023
Merged

fix: Dashboard fullscreen is removing custom URL params #25028

merged 1 commit into from
Aug 18, 2023

Conversation

michael-s-molina
Copy link
Member

SUMMARY

This PR changes the dashboard fullscreen feature to:

  • Preserve custom URL parameters when toggling fullscreen
  • Stop publishing empty preselect_filters param

Fixes #25024

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2023-08-18.at.11.44.26.mov
Screen.Recording.2023-08-18.at.11.32.32.mov

TESTING INSTRUCTIONS

Check the videos for instructions.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina mentioned this pull request Aug 18, 2023
Closed
@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Aug 18, 2023
justinpark
justinpark approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@justinpark justinpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@john-bodley john-bodley added the review:checkpoint Last PR reviewed during the daily review standup label Aug 18, 2023
@michael-s-molina michael-s-molina merged commit 0be1754 into apache:master Aug 18, 2023
27 checks passed
michael-s-molina added a commit that referenced this pull request Aug 21, 2023
@michael-s-molina
fix: Dashboard fullscreen is removing custom URL params (#25028)
a5a027d 
(cherry picked from commit 0be1754)
@michael-s-molina michael-s-molina removed the review:checkpoint Last PR reviewed during the daily review standup label Sep 18, 2023
@mistercrunch mistercrunch added 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@michael-s-molina
fix: Dashboard fullscreen is removing custom URL params (apache#25028)
bef5cfc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinpark justinpark justinpark approved these changes

@kgabryje kgabryje Awaiting requested review from kgabryje

@villebro villebro Awaiting requested review from villebro

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unexpected Error on Exit Fullscreen
4 participants
@michael-s-molina @justinpark @mistercrunch @john-bodley