build(deps): Bump PyHive #25030
Merged
build(deps): Bump PyHive #25030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdeshmu
requested review from
villebro,
geido,
eschutho,
rusackas,
betodealmeida,
nytai,
mistercrunch,
craig-rueda,
john-bodley and
kgabryje
as code owners
john-bodley
reviewed
Aug 19, 2023
john-bodley
reviewed
Aug 21, 2023
mdeshmu
force-pushed
the
bump-pyhive
branch
3 times, most recently
from
b6ece7b
to
7631b28
Compare
bkyryliuk
approved these changes
Aug 23, 2023
|
LG%fix precommit |
rebased with master and pre-commit got fixed |
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
PyHive added support for Python 3.11 and SQLAlchemy 2.0 recently.
pure-sasl library is installed in all PY versions since it is a dependency of thrift-sasl, a dependency of PyHive.
PY < 3.11: sasl library will be installed and used as PyHive's code gives it first preference.
PY >= 3.11 Only pure-sasl library will be installed and used.
test-postgres-hiveCI test in this repo will always pure-sasl because PY 11 test cases fail if sasl is installed.Note:
'pyhive[hive]'extras uses sasl that doesn't support Python 3.11, See cloudera/python-sasl#30. Hence PyHive also supports pure-sasl via additional extras'pyhive[hive_pure_sasl]'which support Python 3.11 along with all previous Python versions.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
PY 3.11: https://github.com/apache/superset/actions/runs/5945658123/job/16125068727?pr=25030
PY 3.10: https://github.com/apache/superset/actions/runs/5945651721/job/16125052276?pr=25030
PY 3.9: https://github.com/apache/superset/actions/runs/5945685670/job/16125136349?pr=25030
cc: @EugeneTorap @bkyryliuk
ADDITIONAL INFORMATION