chore: Organizes the files of the ReportModal feature #25046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-s-molina
requested review from
rusackas,
justinpark,
kgabryje and
geido
| @@ -130,7 +129,6 @@ function mapDispatchToProps(dispatch) { | |||
| dashboardInfoChanged, | |||
| dashboardTitleChanged, | |||
| updateDataMask, | |||
| fetchUISpecificReport, | |||
There was a problem hiding this comment.
This was not being used anywhere. The only reference to fetchUISpecificReport is in HeaderReportDropdown which imports the action directly.
mistercrunch
added
🏷️ bot
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR moves the files of the
ReportModalfeature into a folder undersrc/features/reportsfollowing the guidelines of SIP-61. Previously,ReportModalwas undersrc/componentsbut it's not in the same category as it contains Redux interaction and Superset specific features.This work is part of SIP-61.
TESTING INSTRUCTIONS
CI should be sufficient.
ADDITIONAL INFORMATION