Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cross filters initial scope #25074

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

This PR fixes a bug in the initialization of cross filters scope. The algorithm was not considering dashboards that were created before DASHBOARD_CROSS_FILTERS was enabled. metadata.global_chart_configuration.scope might not exist and that was generating an error.

Fixes #25064

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screenshot 2023-08-24 at 11 23 03 Screenshot 2023-08-24 at 11 22 41

TESTING INSTRUCTIONS

  • Create a dashboard with DASHBOARD_CROSS_FILTERS disabled
  • Enable DASHBOARD_CROSS_FILTERS
  • Navigate to the created dashboard
  • It should not throw the mentioned error

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Aug 24, 2023
@michael-s-molina michael-s-molina merged commit f584c84 into apache:master Aug 24, 2023
27 checks passed
michael-s-molina added a commit that referenced this pull request Aug 24, 2023
@john-bodley john-bodley added review:checkpoint Last PR reviewed during the daily review standup and removed review:checkpoint Last PR reviewed during the daily review standup labels Aug 24, 2023
@trixieboyle
Copy link

SUMMARY

This PR fixes a bug in the initialization of cross filters scope. The algorithm was not considering dashboards that were created before DASHBOARD_CROSS_FILTERS was enabled. metadata.global_chart_configuration.scope might not exist and that was generating an error.

Fixes #25064

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screenshot 2023-08-24 at 11 23 03 Screenshot 2023-08-24 at 11 22 41

TESTING INSTRUCTIONS

  • Create a dashboard with DASHBOARD_CROSS_FILTERS disabled
  • Enable DASHBOARD_CROSS_FILTERS
  • Navigate to the created dashboard
  • It should not throw the mentioned error

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

com.google.android.apps.photos.PDF

cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect dashboard opens when clicking on dashboard title
5 participants