Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(reports): add metrics to report schedule and log prune #25080

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

villebro
Copy link
Member

SUMMARY

We've recently run into an issue with Celery worker processes becoming idle that's likely caused by an open regression in Celery 5 (see celery/celery#7276 for more details). While downgrading to Celery 4 isn't an option, one way of ensuring Alerts & Reports are running is monitoring the scheduling tasks. This PR adds a StatsD metric to reports.scheduler, and while at it, also does the same for reports.execute and reports.prune_log.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@villebro villebro merged commit 04bb73c into apache:master Aug 25, 2023
30 checks passed
@villebro villebro deleted the villebro/reports-statsd branch August 28, 2023 20:20
sadpandajoe added a commit to preset-io/superset that referenced this pull request Aug 29, 2023
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants