Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: preventing save button from flickering in SQL Lab #25106

Merged
merged 6 commits into from
Sep 26, 2023
Merged

fix: preventing save button from flickering in SQL Lab #25106

merged 6 commits into from
Sep 26, 2023

Commits on Sep 26, 2023

  1. preventing save button from rendering prior to evaluating canExploreD… 

    …atabase
    @fisjac
    fisjac committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    9b95ca8 View commit details
    Browse the repository at this point in the history

  2. changing null to false

    @fisjac
    fisjac committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    cc6ee44 View commit details
    Browse the repository at this point in the history

  3. adding back hide logic after erroneously removed

    @fisjac
    fisjac committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    2aa0080 View commit details
    Browse the repository at this point in the history

  4. adjusting logic to prevent render only when allows_virtual_table_expl… 

    …ore is undefined rather than falsey. Adjusting tests for this behavior.
    @fisjac
    fisjac committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    97a92a4 View commit details
    Browse the repository at this point in the history

  5. fixing conditional expect error in test case

    @fisjac
    fisjac committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    513f8eb View commit details
    Browse the repository at this point in the history

  6. changing canShowSaveButton to shouldShowSaveButton

    @fisjac
    fisjac committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    57327bf View commit details
    Browse the repository at this point in the history