Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move TypedDict from typing_extensions to typing #25121

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

sebastianliebscher
Copy link
Contributor

@sebastianliebscher sebastianliebscher commented Aug 30, 2023

SUMMARY

This PR moves TypedDicts from typing_extensions to typing as they are built-in since Python 3.8.

The typing_extensions module serves two related purposes:

Enable use of new type system features on older Python versions. For example, typing.TypeGuard is new in Python 3.10, but typing_extensions allows users on previous Python versions to use it too.
Enable experimentation with new type system PEPs before they are accepted and added to the typing module.

Additionally I

  • fixed some spelling
  • used walrus := if I found the opportunity and simplified code

TESTING INSTRUCTIONS

unit + integration tests run successfully as code has been simplified. No functionality has been changed.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

- fix some spelling
- use walrus :=
@sebastianliebscher sebastianliebscher marked this pull request as ready for review August 30, 2023 09:36
@john-bodley
Copy link
Member

Thanks for the cleanup @sebastianliebscher.

@john-bodley john-bodley merged commit 067bfbf into apache:master Aug 30, 2023
54 checks passed
@sebastianliebscher sebastianliebscher deleted the typing_typeddict branch August 30, 2023 21:53
darwinsubramaniam pushed a commit to darwinsubramaniam/superset that referenced this pull request Sep 7, 2023
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants