chore: Add a note about adhoc subqueries in UPDATING.md #25161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-s-molina
added
the
v3.0
michael-s-molina
commented
Sep 1, 2023
| @@ -24,7 +24,7 @@ assists people when migrating to a new version. | |||
|
|
|||
| ## Next | |||
|
|
|||
| - [25053](https://github.com/apache/superset/pull/25053): Extends the `ab_user.email` column from 64 to 320 characters which has an associated unique key constraint. This will be problematic for MySQL metadata databases which use the InnoDB storage engine with the `innodb_large_prefix` parameter disabled as the key prefix limit is 767 bytes. Enabling said parameter and ensuring that the table uses either the `DYNAMIC` or `COMPRESSED` row format should remedy the problem. See [here](https://dev.mysql.com/doc/refman/5.7/en/innodb-limits.html) for more details. | |||
| - [25053](https://github.com/apache/superset/pull/25053): Extends the `ab_user.email` column from 64 to 320 characters which has an associated unique key constraint. This will be problematic for MySQL metadata databases which use the InnoDB storage engine with the `innodb_large_prefix` parameter disabled as the key prefix limit is 767 bytes. Enabling said parameter and ensuring that the table uses either the `DYNAMIC` or `COMPRESSED` row format should remedy the problem. See [here](https://dev.mysql.com/doc/refman/5.7/en/innodb-limits.html) for more details. | |||
There was a problem hiding this comment.
Just formatting.
This was referenced Sep 1, 2023
john-bodley
reviewed
Sep 1, 2023
UPDATING.md
Outdated
| @@ -43,6 +43,7 @@ assists people when migrating to a new version. | |||
| make it more clear which envrionment your are in. | |||
| `SUPERSET_ENV=production` and `SUPERSET_ENV=development` are the two | |||
| supported switches based on the default config. | |||
| - [19242](https://github.com/apache/superset/pull/19242): Adhoc subqueries were disabled by default for security reasons. To enable them, set `ALLOW_ADHOC_SUBQUERY` to `True` in your `superset_config.py`. | |||
There was a problem hiding this comment.
I think we can scratch the in your … part. I gather (per other updates) this is implicitly implied and the actual filename could vary by deployment.
There was a problem hiding this comment.
"were" may be read as "have been in the past but are now something else". Could we reword that to "are now" or something more explicit?
john-bodley
approved these changes
Sep 1, 2023
michael-s-molina
added a commit
that referenced
this pull request
Sep 5, 2023
darwinsubramaniam
pushed a commit
to darwinsubramaniam/superset
that referenced
this pull request
Sep 7, 2023
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
mistercrunch
added
🍒 3.0.0
🍒 3.0.1
🍒 3.0.2
🍒 3.0.3
🍒 3.0.4
🏷️ bot
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
#19242 disabled adhoc subqueries by default but didn't add anything to
UPDATING.md. This PR adds a note about that change to inform uses about the new feature flag.ADDITIONAL INFORMATION