Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Clearing the currency format has no effect on the chart #25238

Merged
merged 1 commit into from
Sep 11, 2023
Merged

fix: Clearing the currency format has no effect on the chart #25238

merged 1 commit into from
Sep 11, 2023

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Fixes a problem with the Currency Format control where clearing the control wouldn't have any effect on the chart.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2023-09-08.at.17.01.34.mov
Screen.Recording.2023-09-08.at.16.51.57.mov

TESTING INSTRUCTIONS

Check the videos for instructions.

ADDITIONAL INFORMATION

  • Has associated issue: Bugs with the currency format control #25234
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina mentioned this pull request Sep 8, 2023
Closed
3 tasks
@kgabryje
Copy link
Member

Thanks for the fix!

@michael-s-molina michael-s-molina merged commit 6f4e631 into apache:master Sep 11, 2023
27 checks passed
@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Sep 11, 2023
michael-s-molina added a commit that referenced this pull request Sep 11, 2023
@michael-s-molina
fix: Clearing the currency format has no effect on the chart (#25238)
2f1ce7f 
(cherry picked from commit 6f4e631)
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@michael-s-molina
fix: Clearing the currency format has no effect on the chart (apache#…
b281fde 
…25238)
@mistercrunch mistercrunch added 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@michael-s-molina
fix: Clearing the currency format has no effect on the chart (apache#…
f9deefc 
…25238)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgabryje kgabryje kgabryje approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michael-s-molina @kgabryje @mistercrunch