Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dockefile): broken docker image #25251

Merged
merged 2 commits into from
Sep 11, 2023
Merged

fix(dockefile): broken docker image #25251

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cb47d23
Fix broken docker image
hugosjoberg Sep 11, 2023
b47f94a
Update and Innstall in same RUN command
hugosjoberg Sep 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,14 @@ ARG BUILDPLATFORM=${BUILDPLATFORM:-amd64}
FROM --platform=${BUILDPLATFORM} node:16-slim AS superset-node

ARG NPM_BUILD_CMD="build"

RUN apt-get update -q \
&& apt-get install -yq --no-install-recommends \
python3 \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we pin the python3 lib here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's best to pin it for sure, however python3.9 is not available in the package manager. The alternative is to install python from source, however that takes additional time.

Totally open to alternative solutions as well

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understood. I'm fine with this, assuming it's needed to build some NPM libs locally...

make \
gcc \
g++

ENV BUILD_CMD=${NPM_BUILD_CMD} \
PUPPETEER_SKIP_CHROMIUM_DOWNLOAD=true
# NPM ci first, as to NOT invalidate previous steps except for when package.json changes
Expand Down
Loading