Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add line height to metadata bar #25268

Merged
merged 1 commit into from
Sep 12, 2023
Merged

fix: Add line height to metadata bar #25268

merged 1 commit into from
Sep 12, 2023

Conversation

kgabryje
Copy link
Member

@kgabryje kgabryje commented Sep 12, 2023 •
edited
Loading

SUMMARY

Letters like "g" were cut off a bit in a metadata bar.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

image

After:

image

TESTING INSTRUCTIONS

Open a metadata bar which has text that contains letters like "g" (that go below the baseline) and verify they're not cut off

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina merged commit 242921b into apache:master Sep 12, 2023
29 checks passed
@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Sep 12, 2023
michael-s-molina pushed a commit that referenced this pull request Sep 12, 2023
@kgabryje @michael-s-molina
fix: Add line height to metadata bar (#25268)
1498c21 
(cherry picked from commit 242921b)
@john-bodley john-bodley added review:checkpoint Last PR reviewed during the daily review standup and removed review:checkpoint Last PR reviewed during the daily review standup labels Sep 12, 2023
eschutho pushed a commit to Superset-Community-Partners/superset that referenced this pull request Sep 21, 2023
@kgabryje @eschutho
fix: Add line height to metadata bar (apache#25268)
0db07d1
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@kgabryje
fix: Add line height to metadata bar (apache#25268)
0eb88c8
@mistercrunch mistercrunch added 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michael-s-molina michael-s-molina michael-s-molina approved these changes

@geido geido Awaiting requested review from geido geido is a code owner

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch 🍒 3.0.0 🍒 3.0.1 🍒 3.0.2 🍒 3.0.3 🍒 3.0.4 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kgabryje @michael-s-molina @mistercrunch @john-bodley