Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: changing one word (disablement -> disabling) #25291

Merged
merged 1 commit into from
Sep 14, 2023

Conversation

rusackas
Copy link
Member

SUMMARY

Literally just changing a word... since disablement usually refers to the onset of mental or physical disabilities more so than software configuration.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

N/A

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Since disablement refers to mental or physical disabilities more so than software configuration.
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #25291 (baa444a) into master (426aa77) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #25291   +/-   ##
=======================================
  Coverage   69.07%   69.07%           
=======================================
  Files        1905     1905           
  Lines       74721    74721           
  Branches     8270     8270           
=======================================
+ Hits        51610    51611    +1     
+ Misses      20974    20973    -1     
  Partials     2137     2137           
Flag Coverage Δ
hive 53.71% <ø> (ø)
javascript 56.14% <ø> (ø)
mysql 78.43% <ø> (ø)
postgres 78.53% <ø> (+0.01%) ⬆️
presto 53.66% <ø> (ø)
python 82.95% <ø> (+<0.01%) ⬆️
sqlite 77.17% <ø> (ø)
unit 55.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rusackas rusackas merged commit 78cbdc3 into master Sep 14, 2023
56 checks passed
eschutho pushed a commit to Superset-Community-Partners/superset that referenced this pull request Sep 21, 2023
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
@mistercrunch mistercrunch deleted the disablement-to-disabling branch March 26, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants