Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Update correct version tag for 3.0.0 in Chart.yaml #25380

Closed
wants to merge 1 commit into from
Closed

fix: Update correct version tag for 3.0.0 in Chart.yaml #25380

wants to merge 1 commit into from

Conversation

aptro
Copy link

@aptro aptro commented Sep 24, 2023

SUMMARY

It has incorrect default tag, that is making pods to crash. updating to 3.0.0 fixes the issue

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@aptro aptro changed the title Update correct version for 3.0.0 Chart.yaml Update correct version tag for 3.0.0 in Chart.yaml Sep 24, 2023
github-actions[bot]
github-actions bot reviewed Sep 24, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@michael-s-molina michael-s-molina changed the title Update correct version tag for 3.0.0 in Chart.yaml fix: Update correct version tag for 3.0.0 in Chart.yaml Sep 25, 2023
michael-s-molina
michael-s-molina approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-s-molina michael-s-molina added v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch and removed v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch labels Sep 25, 2023
@michael-s-molina
Copy link
Member

Duplicate of #25380.

@michael-s-molina michael-s-molina mentioned this pull request Sep 26, 2023
Closed
@sebastianliebscher
Copy link
Contributor

Duplicate of #25373

@craig-rueda
Copy link
Member

Duplicate of #25373

@craig-rueda craig-rueda marked this as a duplicate of #25373 Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@michael-s-molina michael-s-molina michael-s-molina approved these changes

@craig-rueda craig-rueda Awaiting requested review from craig-rueda craig-rueda is a code owner

@dpgaspar dpgaspar Awaiting requested review from dpgaspar dpgaspar is a code owner

@villebro villebro Awaiting requested review from villebro villebro is a code owner

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aptro @michael-s-molina @sebastianliebscher @craig-rueda