chore(frontend): Spelling #25452

jsoref · 2023-09-28T22:53:25Z

SUMMARY

Spelling fixes for the frontend

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

jsoref · 2023-09-28T22:53:54Z

superset-frontend/cypress-base/cypress/e2e/dashboard/utils.ts

- * Collapes Native Filter from the left panel on dashboard
+ * Collapses Native Filter from the left panel on dashboard
 * @returns {None}
- * @summary helper for collape native filter
+ * @summary helper for collapse native filter


I have a feeling we talked about this in the past, but I'm not certain...

jsoref · 2023-09-28T22:54:33Z

...end/packages/superset-ui-demo/storybook/stories/plugins/plugin-chart-pivot-table/testData.ts

-      program_language: 'Javscript',
+      program_language: 'JavaScript',


similarly.

fwiw, I threw out my baseline because I wanted to test the next version of check-spelling...

jsoref · 2023-09-28T22:54:51Z

superset-frontend/plugins/legacy-plugin-chart-partition/src/Partition.js

-    // When clicking a subdivision, the vis will zoom in to it
+    // When clicking a subdivision, the vis will zoom into it


often controversial

jsoref · 2023-09-28T22:55:56Z

superset-frontend/cypress-base/cypress/e2e/sqllab/_skip.sourcePanel.index.test.js

-  // TODO the test bellow is flaky, and has been disabled for the time being
+  // TODO the test below is flaky, and has been disabled for the time being


This is actually a word: https://www.merriam-webster.com/dictionary/bellow, but it's almost never right, so I now reject it by default in spell-check-this: https://github.com/check-spelling/spell-check-this/blob/b968ca32e0e5961a85c7fe3e9431f81553c3f434/.github/actions/spelling/reject.txt#L2

jsoref · 2023-09-28T22:56:36Z

superset-frontend/packages/superset-ui-core/test/query/processExtraFormData.test.ts

-  it('should assign allowed non-existent value', () => {
+  it('should assign allowed nonexistent value', () => {


often controversial (I can't find the discussion)

jsoref · 2023-09-28T23:01:12Z

superset-frontend/src/dashboard/util/getDashboardUrl.test.js

-        search: '?unkown_param=value',
+        search: '?unknown_param=value',


always unclear when tests do things like this what they're testing...

jsoref · 2023-09-28T23:01:21Z

superset-frontend/src/explore/components/controls/DatasourceControl/index.jsx

-    const isGranularitySqalTemporal = columns.find(
+    const isGranularitySqlaTemporal = columns.find(


jsoref · 2023-09-28T23:01:44Z

superset-frontend/src/pages/DatasetList/DatasetList.test.tsx

-        .find('#duplicate-action-tooltop')
+        .find('#duplicate-action-tooltip')


It looks like you got it in the other location where it's set, so we should be fine.

jsoref · 2023-09-28T23:02:26Z

superset-frontend/src/setup/setupApp.ts

-  // setup appwide custom error messages
+  // set up app wide custom error messages


notable. setup is a noun but this wants the verb-phrase, and there's no particularly good reason to merge app+wide

arguably it should be app-wide.

... but I won't lose any sleep over that.

jsoref · 2023-09-28T23:02:46Z

superset-frontend/tools/eslint-plugin-translation-vars/index.js

-                  "Don't use variables in translation string templates. Flask-babel is a static translation translation service, so it can’t handle strings that include variables",
+                  "Don't use variables in translation string templates. Flask-babel is a static translation service, so it can’t handle strings that include variables",


duplicate words are usually typos...

jsoref · 2023-09-28T23:37:43Z

superset/translations/en/LC_MESSAGES/messages.json

Sadly, these files are a mix of frontend/backend. I should have looked more carefully...

jsoref · 2023-09-28T23:57:53Z

superset-frontend/cypress-base/cypress/e2e/dashboard/nativeFilters.test.ts

-function openMoreFilters(intercetFilterState = true) {
+function openMoreFilters(waitFilterState = true) {
  interceptFilterState();
  cy.getBySel('dropdown-container-btn').click();

-  if (intercetFilterState) {
+  if (waitFilterState) {


This typo meant that people didn't realize that they were almost shadowing a function. I've renamed the argument to wait instead of intercept to more accurately describe what the boolean guards...

superset-frontend/packages/superset-ui-core/test/chart/components/ChartDataProvider.test.tsx

rusackas · 2023-09-29T20:47:24Z

superset-frontend/plugins/legacy-preset-chart-nvd3/src/NVD3Controls.tsx

@@ -170,7 +170,7 @@ export const showControls: CustomControlItem = {
    default: false,
    description: t(
      'Whether to show extra controls or not. Extra controls ' +
-        'include things like making mulitBar charts stacked ' +
+        'include things like making multiBar charts stacked ' +


this might actually need to be multi-bar... but what you have here is an improvement, so that's fine :D

rusackas · 2023-09-29T20:54:37Z

superset-frontend/src/pages/DatasetList/index.tsx

@@ -493,7 +493,7 @@ const DatasetList: FunctionComponent<DatasetListProps> = ({
              )}
              {canDuplicate && original.kind === 'virtual' && (
                <Tooltip
-                  id="duplicate-action-tooltop"
+                  id="duplicate-action-tooltip"


here's the instance you caught (thanks!) that affects the script elsewhere.

rusackas

LGTM! There's a few things we could nit-pick, perhaps, but this is a ton of nice fixes... let's merge it when CI passes!

rusackas · 2023-09-30T05:17:46Z

Codeowner stamp needed from @kgabryje @geido or @michael-s-molina

rusackas · 2024-08-20T20:48:48Z

Oof... not so sure about this one @jsoref - looks like a more painful rebase situation than the other PR :D

jsoref · 2024-08-20T20:52:12Z

lemme look...

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref · 2024-08-20T21:03:55Z

@rusackas: rebased -- thankfully single correction scoped commits isn't as daunting as a squashed quagmire when rebasing :)

superset-frontend/src/components/Button/Button.test.tsx

jsoref requested review from jinghua-qa, geido, eschutho, rusackas, betodealmeida, michael-s-molina and kgabryje as code owners September 28, 2023 22:53

pull-request-size bot added the size/L label Sep 28, 2023

jsoref commented Sep 28, 2023

View reviewed changes

jsoref force-pushed the spelling-frontend branch 3 times, most recently from f0834ea to 4c64aa8 Compare September 28, 2023 23:35

jsoref commented Sep 28, 2023

View reviewed changes

jsoref force-pushed the spelling-frontend branch from 4c64aa8 to 4f8360c Compare September 28, 2023 23:56

jsoref commented Sep 28, 2023

View reviewed changes

john-bodley reviewed Sep 29, 2023

View reviewed changes

superset-frontend/packages/superset-ui-core/test/chart/components/ChartDataProvider.test.tsx Outdated Show resolved Hide resolved

rusackas reviewed Sep 29, 2023

View reviewed changes

rusackas approved these changes Sep 29, 2023

View reviewed changes

jsoref added 8 commits August 20, 2024 16:55

spelling: app wide

737dc13

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: assignment

433ec4a

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: below

7e7eeca

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: clickable

b44f04e

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: collapse

3547f08

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: collapses

b22e577

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: columnoption

85b9065

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: concurrently

12c6b7b

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref added 19 commits August 20, 2024 17:01

spelling: separate

1adf786

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: session

8b29c15

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: set up

1dd4b6d

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: source

d32a616

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: specific

a4f6b67

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: specified

df082b9

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: sqla

4150685

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: storybook

45d4a80

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: syntax

421151b

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: tab should

1792a0a

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: tooltip

d8a3ef8

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: transform

aa87dc1

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: translation

48a77e9

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: twitch

ca17c78

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: typescript

21843cf

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: unknown

d756e33

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: value

de58b1f

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: wait

38c791f

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

spelling: when

475ff79

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>

jsoref force-pushed the spelling-frontend branch from 2b7a758 to 475ff79 Compare August 20, 2024 21:02

github-actions bot added i18n Namespace | Anything related to localization plugins packages labels Aug 20, 2024

Merge branch 'master' into spelling-frontend

5254b7c

geido approved these changes Sep 9, 2024

View reviewed changes

rusackas reviewed Sep 9, 2024

View reviewed changes

superset-frontend/src/components/Button/Button.test.tsx Outdated Show resolved Hide resolved

Update superset-frontend/src/components/Button/Button.test.tsx

5464ed8

rusackas merged commit d0c9cde into apache:master Sep 10, 2024
34 checks passed

jsoref deleted the spelling-frontend branch September 10, 2024 21:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(frontend): Spelling #25452

chore(frontend): Spelling #25452

jsoref commented Sep 28, 2023

jsoref Sep 28, 2023

jsoref Sep 28, 2023

jsoref Sep 28, 2023

jsoref Sep 28, 2023

jsoref Sep 28, 2023

jsoref Sep 28, 2023

jsoref Sep 28, 2023

jsoref Sep 28, 2023

rusackas Sep 29, 2023

jsoref Sep 28, 2023

rusackas Sep 29, 2023

rusackas Sep 29, 2023

jsoref Sep 28, 2023

jsoref Sep 28, 2023

jsoref Sep 28, 2023

rusackas Sep 29, 2023

rusackas Sep 29, 2023

rusackas left a comment

rusackas commented Sep 30, 2023

rusackas commented Aug 20, 2024

jsoref commented Aug 20, 2024

jsoref commented Aug 20, 2024

		program_language: 'Javscript',
		program_language: 'JavaScript',

		// When clicking a subdivision, the vis will zoom in to it
		// When clicking a subdivision, the vis will zoom into it

		// TODO the test bellow is flaky, and has been disabled for the time being
		// TODO the test below is flaky, and has been disabled for the time being

		it('should assign allowed non-existent value', () => {
		it('should assign allowed nonexistent value', () => {

		search: '?unkown_param=value',
		search: '?unknown_param=value',

		const isGranularitySqalTemporal = columns.find(
		const isGranularitySqlaTemporal = columns.find(

		.find('#duplicate-action-tooltop')
		.find('#duplicate-action-tooltip')

		// setup appwide custom error messages
		// set up app wide custom error messages

		"Don't use variables in translation string templates. Flask-babel is a static translation translation service, so it can’t handle strings that include variables",
		"Don't use variables in translation string templates. Flask-babel is a static translation service, so it can’t handle strings that include variables",

chore(frontend): Spelling #25452

chore(frontend): Spelling #25452

Conversation

jsoref commented Sep 28, 2023

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

rusackas left a comment

Choose a reason for hiding this comment

rusackas commented Sep 30, 2023

rusackas commented Aug 20, 2024

jsoref commented Aug 20, 2024

jsoref commented Aug 20, 2024