Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: adding resource links to readme #25629

Merged
merged 2 commits into from
Oct 13, 2023
Merged

chore: adding resource links to readme #25629

merged 2 commits into from
Oct 13, 2023

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented Oct 12, 2023 •
edited
Loading

SUMMARY

It was not easy to find certain things, so I've added them to the readme:

  • the In the Wild page, and other markdown files on the repo that have no links to them
  • Instructions to actually join the dev mailing list
  • The superset wiki
  • The database rolodex doc
  • The SIP board
  • The community calendar

Maybe this'll boost some visibility/engagement?

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

n/a

TESTING INSTRUCTIONS

read, and click links ;)

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Oct 12, 2023 •
edited
Loading

Codecov Report

Merging #25629 (ea2f7a7) into master (ef1807c) will decrease coverage by 0.01%.
Report is 5 commits behind head on master.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #25629      +/-   ##
==========================================
- Coverage   68.99%   68.99%   -0.01%     
==========================================
  Files        1931     1931              
  Lines       75506    75506              
  Branches     8402     8402              
==========================================
- Hits        52096    52093       -3     
- Misses      21250    21253       +3     
  Partials     2160     2160
Flag Coverage Δ
hive 53.69% <ø> (ø)
javascript 56.14% <ø> (-0.01%) ⬇️
mysql 78.32% <ø> (ø)
postgres 78.42% <ø> (+0.01%) ⬆️
presto 53.64% <ø> (ø)
python 82.88% <ø> (ø)
sqlite 77.07% <ø> (ø)
unit 55.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

sfirke
sfirke approved these changes Oct 13, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
README.md
- [Standard Roles](RESOURCES/STANDARD_ROLES.md) - How RBAC permissions map to roles.
- [Superset Wiki](https://github.com/apache/superset/wiki) - Tons of additional community resources: best practices, community content and other information.
- [Superset SIPs](https://github.com/orgs/apache/projects/170) - The status of Superset's SIPs (Superset Improvment Proposals) for both consensus and implementation status.

Superset 2.0!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Want to update these to 3.0.0 links, as long as you're in here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I'll actually put all of these on the Wiki in an orderly fashion and delete these, in a subsequent PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maintaining the Wiki (and directing traffic to it) is MUCH easier than opening PRs for every webinar link ;)

@sfirke
Copy link
Member

sfirke commented Oct 13, 2023

nice additions, thanks Evan!

@rusackas @sfirke
Update README.md
ea2f7a7 
syncs are so passé - let's just have meetings.

Co-authored-by: Sam Firke <sfirke@users.noreply.github.com>
@sfirke sfirke added the merge-if-green If approved and tests are green, please go ahead and merge it for me label Oct 13, 2023
@rusackas rusackas merged commit e878303 into master Oct 13, 2023
51 checks passed
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@rusackas @sfirke
chore: adding resource links to readme (apache#25629)
fdc549a 
Co-authored-by: Sam Firke <sfirke@users.noreply.github.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
sfirke added a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@rusackas @sfirke
chore: adding resource links to readme (apache#25629)
3d70767 
Co-authored-by: Sam Firke <sfirke@users.noreply.github.com>
@mistercrunch mistercrunch deleted the resource-links branch March 26, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfirke sfirke sfirke approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels merge-if-green If approved and tests are green, please go ahead and merge it for me size/S 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rusackas @sfirke @mistercrunch