fix: Added chart examples for left out chart types #26387
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #26387 +/- ##
=======================================
Coverage 69.14% 69.14%
=======================================
Files 1946 1946
Lines 75989 75989
Branches 8479 8479
=======================================
Hits 52544 52544
Misses 21266 21266
Partials 2179 2179
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sivasathyaseeelan
changed the title
|
Thank you for the PR @sivasathyaseeelan. Could you rebase your PR and check how it overlaps with #25770? Maybe you can discard some of your changes. |
…ache#26363) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…t-websocket (apache#26386) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: Willie Hung <willie880201044@gmail.com>
…r: Item with key ... is not registered. (apache#26398)
sivasathyaseeelan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added chart examples for left out chart types and modified VizTypeGallery.tsx for rendering thumbnail image in case of no example provided
SUMMARY
Adding chart examples for Deck.gl:
And made a change in VizTypeGallery.tsx for rendering thumbnail image in case of no example provided
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE
AFTER
Screencast.from.01-01-24.02.37.27.PM.IST.webm
TESTING INSTRUCTIONS
Kindly go to http://localhost:9000/chart/add and please select any chart so that you can be able to see example images of selected chart
ADDITIONAL INFORMATION