-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(celery): upgrade celery and its dependencies packages #26604
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26604 +/- ##
==========================================
- Coverage 69.16% 69.16% -0.01%
==========================================
Files 1948 1948
Lines 76062 76062
Branches 8493 8493
==========================================
- Hits 52609 52606 -3
- Misses 21273 21276 +3
Partials 2180 2180
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very cool, thanks for the PR @Musa10 I wasn't aware that Celery moves so quickly; here's the changelog: https://docs.celeryq.dev/en/stable/changelog.html#version-5-3-6. Lots of things have indeed changed since 5.2.2, and I get the feeling 5.3.6 is indeed more stable than 5.2.2, despite those yanked 5.3.2-5.3.4.
@dpgaspar @betodealmeida @john-bodley with all these nice improvements in 5.3.6 vs 5.2.2, do you think we should also set the lower bound to 5.3.6, rather than just bump the lock files? |
Btw, I assume this issue is still unresolved.. 🙁 celery/celery#7276 |
@Musa10 currently your PR only impacts the frozen requirements—typically used for CI—hence if you simply In order to ensure Celery is upgraded for all situations you should increase the lower bound in the |
SUMMARY
Upgrading celery packages after a lot of bugs in using cache like memory leakes, backend keep requesting async-event api, that have been occured using basic celery configs, and fixed using celery v5.3.6
TESTING INSTRUCTIONS
Test cache and charts loading with memory usage when loading a dashboard
ADDITIONAL INFORMATION
GLOBAL_ASYNC_QUERIES:TRUE