-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: prevent CI double runs on push + pull_request #26766
Merged
Merged
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
8c01f35
chore: prevent CI double runs on push + pull_request
mistercrunch dfd9567
adressing comments
mistercrunch 61ade6a
dummy
mistercrunch 1930ae5
testing no-op
mistercrunch 2028a79
catching matrix-specific no-op
mistercrunch 2626bb6
fix yaml
mistercrunch ab0b564
testing
mistercrunch 12f1c4e
testing
mistercrunch 554eb4e
fix docker cache hit
mistercrunch d856e17
fix docker cache hit
mistercrunch 52b1fa2
fix docker cache hit
mistercrunch f364847
dummy commit to test docker cache
mistercrunch ddd86f6
trying a different ref
mistercrunch f4db71e
try supreset-cache hub
mistercrunch 6034897
fancy CACHE_REF
mistercrunch 2519ba2
fancy CACHE_REF
mistercrunch 4fbcf6a
dummy commit to test docker cache
mistercrunch 26ca7a8
disabling some builds
mistercrunch File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
# no-op.yml | ||
# | ||
# Purpose: | ||
# This workflow provides a workaround for the "required status checks" feature in GitHub Actions | ||
# when using path-specific conditions in other workflows. Required checks might remain in a "Pending" | ||
# state if the conditions are not met, thus blocking pull requests from being merged. | ||
# This no-op (no operation) workflow provides dummy success statuses for these required jobs when | ||
# the real jobs do not run due to path-specific conditions. | ||
# | ||
# How it works: | ||
# - It defines jobs with the same names as the required jobs in the main workflows. | ||
# - These jobs simply execute a command (`exit 0`) to succeed immediately. | ||
# - When a pull request is created or updated, both this no-op workflow and the main workflows are triggered. | ||
# - If the main workflows' jobs don't run (due to path conditions), these no-op jobs provide successful statuses. | ||
# - If the main workflows' jobs do run and fail, their failure statuses take precedence, | ||
# ensuring that pull requests are not merged with failing checks. | ||
# | ||
# Usage: | ||
# - Ensure that the job names in this workflow match exactly the names of the corresponding jobs in the main workflows. | ||
# - This workflow should be kept as-is, without path-specific conditions. | ||
|
||
name: No Operation Checks | ||
on: pull_request | ||
|
||
jobs: | ||
frontend-build: | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: No-op for frontend-build | ||
run: | | ||
echo "This is a no-op step for frontend-build to ensure a successful status." | ||
exit 0 | ||
|
||
pre-commit: | ||
strategy: | ||
matrix: | ||
python-version: ["3.9"] | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: No-op for pre-commit | ||
run: | | ||
echo "This is a no-op step for pre-commit to ensure a successful status." | ||
exit 0 | ||
|
||
python-lint: | ||
strategy: | ||
matrix: | ||
python-version: ["3.9"] | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: No-op for python-lint | ||
run: | | ||
echo "This is a no-op step for python-lint to ensure a successful status." | ||
exit 0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a path here, eg: