chore: Splits the CHANGELOG into multiple files #26800
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26800 +/- ##
==========================================
+ Coverage 67.16% 67.22% +0.05%
==========================================
Files 1894 1894
Lines 74176 74178 +2
Branches 8243 8244 +1
==========================================
+ Hits 49820 49864 +44
+ Misses 22287 22242 -45
- Partials 2069 2072 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Thanks @michael-s-molina for the cleanup. My only comment is whether there's merit in keeping the |
@john-bodley I applied your suggestion. |
| Apache {{ project_name }} version {{ version }} based on {{ version_rc }} is now closed. | ||
|
|
||
| {% if vote_negatives|length > 0 -%} | ||
| The vote did NOT PASS with {{vote_bindings|length}} binding +1, {{ vote_nonbindings|length}} non-binding +1, and {{vote_negatives|length}} -1 votes: | ||
| {% elif vote_bindings|length > 2 -%} | ||
| The vote PASSED with {{vote_bindings|length}} binding +1, {{ vote_nonbindings|length}} non-binding +1, and {{vote_negatives|length}} -1 votes: | ||
| {% else -%} | ||
| The vote is non conclusive with {{vote_bindings|length}} binding +1, {{ vote_nonbindings|length}} non-binding -1, and {{vote_negatives|length}} -1 votes: | ||
| The vote is non conclusive with {{vote_bindings|length}} binding +1, {{ vote_nonbindings|length}} non-binding +1, and {{vote_negatives|length}} -1 votes: |
There was a problem hiding this comment.
Nice catches. I just wonder if vote_nonbinding is either + OR -? I'm not seeing where this is tabulated to be sure. I'm guessing you're right though :D
There was a problem hiding this comment.
It's defined here.
A List of people with +1 non binding vote (ex: Ville)
mistercrunch
added
🏷️ bot
SUMMARY
Splits the
CHANGELOG.mdinto multiple files to better organize the contents of each release and also to deal with GitHub size limitation when displaying the file. Now every release will have its own file atCHANGELOG/<version>.mdADDITIONAL INFORMATION