Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump dom-to-image-more from 2.16.0 to 3.2.0 in /superset-frontend #26869

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 29, 2024

Bumps dom-to-image-more from 2.16.0 to 3.2.0.

Release notes

Sourced from dom-to-image-more's releases.

More rollup bundling fixes

Fixes

  • Reformatted to match prettier's settings.
  • Rollup bundling errors Fixes #133

Since rollup sees all imports as modules it replaces this with undefined when evaluating the IFE that dom-to-image-more's source exists as. This leads to errors from rollup that are not actually a problem. Found an incantation that rollup won't break with.

Full Changelog*: 1904labs/dom-to-image-more@v3.1.5...v3.1.6

v3.1.5

What's Changed

New Contributors

Full Changelog: 1904labs/dom-to-image-more@v3.1.4...v3.1.5

v3.1.4 - CORS Documentation updates

What's Changed

New Contributors

Full Changelog: 1904labs/dom-to-image-more@v3.1.1...v3.1.4

Fix Firefox image issues and reduce console warnings.

What's Changed

Full Changelog: 1904labs/dom-to-image-more@v3.1.0...v3.1.1

v3.1.0

What's Changed

... (truncated)

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [dom-to-image-more](https://github.com/1904labs/dom-to-image-more) from 2.16.0 to 3.2.0.
- [Release notes](https://github.com/1904labs/dom-to-image-more/releases)
- [Commits](1904labs/dom-to-image-more@v2.16.0...v3.2.0)

---
updated-dependencies:
- dependency-name: dom-to-image-more
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependabot npm Dependabot - npm related PRs labels Jan 29, 2024
Copy link

codecov bot commented Jan 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (806e4c4) 67.24% compared to head (552aec4) 67.24%.
Report is 11 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #26869   +/-   ##
=======================================
  Coverage   67.24%   67.24%           
=======================================
  Files        1895     1895           
  Lines       74248    74248           
  Branches     8257     8257           
=======================================
  Hits        49929    49929           
  Misses      22248    22248           
  Partials     2071     2071           
Flag Coverage Δ
javascript 57.01% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mistercrunch mistercrunch added the hold:testing! On hold for testing label Jan 30, 2024
@mistercrunch
Copy link
Member

dom-to-image-more has no unit / integration tests, would have to be manually tested.

@rusackas
Copy link
Member

/testenv up

Copy link
Contributor

@rusackas Container image not yet published for this PR. Please try again when build is complete.

Copy link
Contributor

@rusackas Ephemeral environment creation failed. Please check the Actions logs for details.

@rusackas
Copy link
Member

Tested manually, seems to work fine.

@rusackas rusackas merged commit 0a335c6 into master Jan 30, 2024
32 checks passed
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/superset-frontend/dom-to-image-more-3.2.0 branch January 30, 2024 20:02
eschutho pushed a commit to preset-io/superset that referenced this pull request Jan 31, 2024
…-frontend (apache#26869)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
…-frontend (apache#26869)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.0.0 labels Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dependabot hold:testing! On hold for testing npm Dependabot - npm related PRs size/XS 🚢 4.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants