feat: docker image tags documentation + tweaks #26923
Conversation
mistercrunch
requested review from
craig-rueda,
dpgaspar and
villebro
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #26923 +/- ##
=======================================
Coverage 67.19% 67.20%
=======================================
Files 1899 1899
Lines 74346 74346
Branches 8263 8263
=======================================
+ Hits 49960 49961 +1
+ Misses 22337 22336 -1
Partials 2049 2049
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mistercrunch
force-pushed
the
docker_docs
branch
from
998584e to
cead807
Compare
mistercrunch
requested review from
geido,
eschutho,
rusackas,
betodealmeida,
nytai,
john-bodley and
kgabryje
as code owners
|
/testenv up |
|
@mistercrunch Ephemeral environment spinning up at http://34.220.34.38:8080. Credentials are |
|
Actions run their |
There was a problem hiding this comment.
Should docs have manual line breaks or should that just happen automatically? I pointed out an instance of that and linked to a recent comment from @john-bodley on this.
Otherwise a few suggestions for clarity but overall this looks great 👍
| ``` | ||
|
|
||
| Presumably, `linux/arm64/v8` would be more optimized for this generation | ||
| of chips, but less compatible across the ARM ecosystem. |
There was a problem hiding this comment.
I'm just not sure if it's 100% true ... seemed to work for me
scripts/build_docker.py
Outdated
| @@ -205,12 +208,14 @@ def get_docker_command( | |||
| ) | |||
| @click.option("--build_context_ref", help="a reference to the pr, release or branch") | |||
| @click.option("--dry-run", is_flag=True, help="Run the command in dry-run mode.") | |||
| @click.option("--force-latest", is_flag=True, help="Run the command in dry-run mode.") | |||
mistercrunch
force-pushed
the
docker_docs
branch
from
4662ccf to
a270ddb
Compare
|
Ephemeral environment shutdown and build artifacts deleted. |
Co-authored-by: Sam Firke <sfirke@users.noreply.github.com>
|
@supersetbot orglabel |
mistercrunch
added
🏷️ bot
Co-authored-by: Sam Firke <sfirke@users.noreply.github.com>
This PR adds a new page to the docs under "Installation and Configuration" titled "Docker Images and Tags"
It also:
PR_5287+ unit tests for thatlatest) since the dev build isn't as secure--force-latestflag to the build_docker.py scriptFor the text, I have GPT proof read it and I rendered it locally, and took a screenshot
