Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix js warnings #2693

Merged
merged 7 commits into from
Apr 29, 2017
Merged

Fix js warnings #2693

merged 7 commits into from
Apr 29, 2017

Commits on Apr 28, 2017

  1. removing babel devDependency because has been deprecated in favor of … 

    …babel-cli

this fixes a warning during `npm install`:
```
npm WARN deprecated babel@6.23.0:
In 6.x, the babel package has been deprecated in favor of babel-cli.
Check https://opencollective.com/babel to support the Babel maintainers
```
    @dennybiasiolli
    dennybiasiolli committed Apr 28, 2017
    Configuration menu
    Copy the full SHA
    4727956 View commit details
    Browse the repository at this point in the history

  2. react: using prop-types package to fix deprecated React.PropTypes pro… 

    …perty warning

https://facebook.github.io/react/warnings/dont-call-proptypes.html
    @dennybiasiolli
    dennybiasiolli committed Apr 28, 2017
    Configuration menu
    Copy the full SHA
    4a75975 View commit details
    Browse the repository at this point in the history

  3. js: setting ExploreActionButtons.queryEndpoint PropType as required 

    because it's required in the child component DisplayQueryButton
    @dennybiasiolli
    dennybiasiolli committed Apr 28, 2017
    Configuration menu
    Copy the full SHA
    6ecdbc9 View commit details
    Browse the repository at this point in the history

  4. js(tests): using object in expandedSlices prop type of SliceCell tests

    @dennybiasiolli
    dennybiasiolli committed Apr 28, 2017
    Configuration menu
    Copy the full SHA
    c15c6e3 View commit details
    Browse the repository at this point in the history

  5. js(tests): adding required props to SqlEditor mockedProps

    @dennybiasiolli
    dennybiasiolli committed Apr 28, 2017
    Configuration menu
    Copy the full SHA
    ba588f3 View commit details
    Browse the repository at this point in the history

  6. js(tests): adding required prop editorHeight to TabbedSqlEditors mock… 

    …edProps
    @dennybiasiolli
    dennybiasiolli committed Apr 28, 2017
    Configuration menu
    Copy the full SHA
    48662b8 View commit details
    Browse the repository at this point in the history

  7. js: removing unused moments dependency

    @dennybiasiolli
    dennybiasiolli committed Apr 28, 2017
    Configuration menu
    Copy the full SHA
    8928938 View commit details
    Browse the repository at this point in the history