fix: Allow only dttm columns in comparison filter in Period over Period chart #27209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antonio-RiveroMartnez
approved these changes
Feb 22, 2024
| @@ -382,7 +382,18 @@ const DndFilterSelect = (props: DndFilterSelectProps) => { | |||
| return new AdhocFilter(config); | |||
| }, [droppedItem]); | |||
|
|
|||
| const canDrop = useCallback(() => true, []); | |||
| const canDrop = useCallback( | |||
There was a problem hiding this comment.
non blocking: does any testable behavior changed with this block? If so, could add include it in the DndMetricSelect.test.tsx file?
There was a problem hiding this comment.
No. The drag and drop behavior tested in DndMetricSelect.test.tsx is related to reordering the metric values. Testing drag and drop from the datasource panel to the control field is more complicated - I suggest we add those tests in a separate PR, both for filters and metrics
| controlState.value, | ||
| ), | ||
| }), | ||
| ) => { |
john-bodley
added
the
review:checkpoint
kgabryje
force-pushed
the
feat/pop-kpi-comparison-only-dttm
branch
from
4ceb9a7
to
5c0be0d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #27209 +/- ##
==========================================
- Coverage 67.34% 67.34% -0.01%
==========================================
Files 1909 1909
Lines 74592 74600 +8
Branches 8320 8323 +3
==========================================
+ Hits 50235 50236 +1
- Misses 22305 22312 +7
Partials 2052 2052
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
john-bodley
removed
the
review:checkpoint
kgabryje
force-pushed
the
feat/pop-kpi-comparison-only-dttm
branch
from
5c0be0d
to
263b76e
Compare
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Mar 7, 2024
…od chart (apache#27209) (cherry picked from commit a4c771e)
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Mar 8, 2024
…od chart (apache#27209) (cherry picked from commit a4c771e)
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Mar 14, 2024
…od chart (apache#27209) (cherry picked from commit a4c771e)
9 tasks
justinpark
added
the
v4.0
michael-s-molina
removed
the
v4.0
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Mar 19, 2024
…od chart (apache#27209) (cherry picked from commit a4c771e)
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Mar 22, 2024
…od chart (apache#27209) (cherry picked from commit a4c771e)
sfirke
pushed a commit
to sfirke/superset
that referenced
this pull request
Mar 22, 2024
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Mar 26, 2024
…od chart (apache#27209) (cherry picked from commit a4c771e)
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Mar 26, 2024
…od chart (apache#27209) (cherry picked from commit a4c771e)
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Mar 28, 2024
…od chart (apache#27209) (cherry picked from commit a4c771e)
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Apr 1, 2024
…od chart (apache#27209) (cherry picked from commit a4c771e)
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
Apr 2, 2024
…od chart (apache#27209) (cherry picked from commit a4c771e)
qleroy
pushed a commit
to qleroy/superset
that referenced
this pull request
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
When user selected Custom range for comparison on Big Number With Time Period Comparison chart, the filter control would accept any column. That worked but didn't make much sense, so this PR restricts the control to accept only dttm columns for filtering.
Please note that user can still write custom sql which will filter anything, so that's just a UX improvement.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2024-02-22.at.18.12.53.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION