Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard,css): center align 'waiting on database' #27611

Merged
merged 2 commits into from
Mar 22, 2024

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Mar 21, 2024

SUMMARY

center-align the text under the loading spinner withing charts in a dashbaord

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

Screenshot 2024-03-21 at 12 25 46 PM

after

Screenshot 2024-03-21 at 12 22 12 PM

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.46%. Comparing base (6f3afab) to head (db6a88a).
Report is 1388 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #27611   +/-   ##
=======================================
  Coverage   67.46%   67.46%           
=======================================
  Files        1910     1910           
  Lines       74812    74812           
  Branches     8346     8346           
=======================================
  Hits        50474    50474           
  Misses      22286    22286           
  Partials     2052     2052           
Flag Coverage Δ
javascript 57.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mistercrunch mistercrunch merged commit 2000735 into master Mar 22, 2024
30 checks passed
@michael-s-molina michael-s-molina added v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch and removed v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch labels Mar 25, 2024
@rusackas rusackas deleted the fix_wait_on_db_wra branch April 3, 2024 04:20
EandrewJones pushed a commit to UMD-ARLIS/superset that referenced this pull request Apr 5, 2024
EnxDev pushed a commit to EnxDev/superset that referenced this pull request Apr 12, 2024
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 4.1.0 labels Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 4.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants