Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump pylint #27711

Merged
merged 1 commit into from
Mar 27, 2024
Merged

chore: bump pylint #27711

merged 1 commit into from
Mar 27, 2024

Conversation

betodealmeida
Copy link
Member

SUMMARY

Bump pylint because CI is failing due to it complaining of things that don't make sense:

************* Module superset.models.helpers
superset/models/helpers.py:39:0: E0611: No name 'escape' in module 'flask' (no-name-in-module)
superset/models/helpers.py:39:0: E0611: No name 'Markup' in module 'flask' (no-name-in-module)
************* Module superset.models.sql_lab
superset/models/sql_lab.py:28:0: E0611: No name 'Markup' in module 'flask' (no-name-in-module)
************* Module superset.tags.models
superset/tags/models.py:22:0: E0611: No name 'escape' in module 'flask' (no-name-in-module)
************* Module superset.views.database.mixins
superset/views/database/mixins.py:19:0: E0611: No name 'Markup' in module 'flask' (no-name-in-module)
************* Module superset.views.chart.mixin
superset/views/chart/mixin.py:17:0: E0611: No name 'Markup' in module 'flask' (no-name-in-module)
************* Module superset.connectors.sqla.views
superset/connectors/sqla/views.py:21:0: E0611: No name 'Markup' in module 'flask' (no-name-in-module)
************* Module superset.connectors.sqla.models
superset/connectors/sqla/models.py:36:0: E0611: No name 'escape' in module 'flask' (no-name-in-module)
superset/connectors/sqla/models.py:36:0: E0611: No name 'Markup' in module 'flask' (no-name-in-module)
************* Module superset.utils.core
superset/utils/core.py:63:0: E0611: No name 'Markup' in module 'flask' (no-name-in-module)
************* Module superset.utils.date_parser
superset/utils/date_parser.py:52:0: E1120: No value for argument 'self' in unbound method call (no-value-for-parameter)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@betodealmeida betodealmeida marked this pull request as ready for review March 27, 2024 16:26
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.77%. Comparing base (86bd7a9) to head (fa7f935).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #27711      +/-   ##
==========================================
+ Coverage   69.76%   69.77%   +0.01%     
==========================================
  Files        1911     1911              
  Lines       75056    75056              
  Branches     8362     8362              
==========================================
+ Hits        52362    52373      +11     
+ Misses      20642    20631      -11     
  Partials     2052     2052              
Flag Coverage Δ
mysql 77.90% <ø> (?)
postgres 78.02% <ø> (ø)
python 82.91% <ø> (+0.03%) ⬆️
sqlite 77.45% <ø> (ø)
unit 56.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@betodealmeida betodealmeida added the merge-if-green If approved and tests are green, please go ahead and merge it for me label Mar 27, 2024
@betodealmeida betodealmeida merged commit a48f770 into master Mar 27, 2024
32 of 47 checks passed
michael-s-molina added a commit to michael-s-molina/superset that referenced this pull request Mar 27, 2024
@rusackas rusackas deleted the bump-pylint branch April 2, 2024 23:09
EandrewJones pushed a commit to UMD-ARLIS/superset that referenced this pull request Apr 5, 2024
EandrewJones pushed a commit to UMD-ARLIS/superset that referenced this pull request Apr 5, 2024
EnxDev pushed a commit to EnxDev/superset that referenced this pull request Apr 12, 2024
EnxDev pushed a commit to EnxDev/superset that referenced this pull request Apr 12, 2024
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge-if-green If approved and tests are green, please go ahead and merge it for me size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants