Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(superset-frontend): remove unused @superset-ui/plugin-chart-period-over-period-kpi package #27994

Conversation

corocoto
Copy link
Contributor

SUMMARY

ADDITIONAL INFORMATION

Fixes #27993

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @corocoto. It seems this was a left over of #27203. @kgabryje

@corocoto corocoto changed the title deps(superset-frontend): remove unused @superset-ui/plugin-chart-period-over-period-kpi package chore(superset-frontend): remove unused @superset-ui/plugin-chart-period-over-period-kpi package Apr 11, 2024
@corocoto
Copy link
Contributor Author

@michael-s-molina, you are welcome! And thanks for your approve. But can you do it again?
Because I changed the PR's title, and the link-check workflow waited an approval from a maintainer again:

image

Thanks!

@michael-s-molina michael-s-molina changed the title chore(superset-frontend): remove unused @superset-ui/plugin-chart-period-over-period-kpi package fix(superset-frontend): remove unused @superset-ui/plugin-chart-period-over-period-kpi package Apr 11, 2024
@michael-s-molina michael-s-molina merged commit 7e679d5 into apache:master Apr 11, 2024
42 of 44 checks passed
@corocoto corocoto deleted the deps/remove-@superset-ui/plugin-chart-period-over-period-kpi branch April 11, 2024 18:27
@michael-s-molina michael-s-molina added the v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch label Apr 12, 2024
EnxDev pushed a commit to EnxDev/superset that referenced this pull request Apr 15, 2024
michael-s-molina pushed a commit that referenced this pull request Apr 16, 2024
michael-s-molina pushed a commit that referenced this pull request Apr 16, 2024
@michael-s-molina michael-s-molina removed the v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch label Apr 16, 2024
qleroy pushed a commit to qleroy/superset that referenced this pull request Apr 28, 2024
jzhao62 pushed a commit to jzhao62/superset that referenced this pull request May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants