Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

explorev2/stores/controls: use default time range #2805

Closed
wants to merge 1 commit into from

Conversation

vavrusa
Copy link
Contributor

@vavrusa vavrusa commented May 24, 2017

The reasoning is that most of the controls use first available value.
7 days is really impractical for huge datasets where it can easily be
petabytes of data, so it makes initial load slow.

The reasoning is that most of the controls use first available value.
7 days is really impractical for huge datasets where it can easily be
petabytes of data, so it makes initial load slow.
@mistercrunch
Copy link
Member

mistercrunch commented May 24, 2017

Might as well hard code '1 hour ago' as choices is static.

1 hour ago is probably impractical as well for batch data of tables loaded daily. Arguably 7 days is a decent default for batch data and 1 hour is decent for realtime data.

The default from time filter could be set at the datasource level, but I doubt people would take the time to alter that configuration setting.

@vavrusa
Copy link
Contributor Author

vavrusa commented May 24, 2017

So arguably neither of them works for all use cases, so what would you prefer we do?

  • Make it configurable in the datasource
  • Do not immediately launch a query as soon as the explore view is opened

For (b) the default wouldn't then matter as the time range is the first thing I change when I open the explore. This is actually one of the most annoying things, it launches query before even giving me a chance to provide any input in the form.

@mistercrunch
Copy link
Member

Closing old PRs with broken build or merge conflict, feel free to re-open once merge conflicts are sorted out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants