Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve visualize modal test coverage #2811

Merged
merged 11 commits into from
May 31, 2017
Merged

Improve visualize modal test coverage #2811

merged 11 commits into from
May 31, 2017

Commits on May 22, 2017

  1. redux visualize modal

    Grace Guo committed May 22, 2017
    Configuration menu
    Copy the full SHA
    2353248 View commit details
    Browse the repository at this point in the history

  2. redux visualize modal 

    - apply redux
- add unit test for connect container component
- fix lint error
    Grace Guo committed May 22, 2017
    Configuration menu
    Copy the full SHA
    5eec1d6 View commit details
    Browse the repository at this point in the history

  3. add unit tests for VisuaizeModal

    Grace Guo committed May 22, 2017
    Configuration menu
    Copy the full SHA
    31cbba8 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2017

  1. add unit tests for VisualizeModal component

    Grace Guo committed May 24, 2017
    Configuration menu
    Copy the full SHA
    132e402 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'supercat/gg-addTestCoverage-VisualizeMo… 

    …dal' into gg-addTestCoverage-VisualizeModal

# Conflicts:
#	superset/assets/javascripts/SqlLab/actions.js
    Grace Guo committed May 24, 2017
    Configuration menu
    Copy the full SHA
    472bcb9 View commit details
    Browse the repository at this point in the history

Commits on May 25, 2017

  1. remove changes on css file (merge by mistake)

    Grace Guo committed May 25, 2017
    Configuration menu
    Copy the full SHA
    8a4f189 View commit details
    Browse the repository at this point in the history

  2. remove changes on css file (merge by mistake)

    Grace Guo committed May 25, 2017
    Configuration menu
    Copy the full SHA
    532845d View commit details
    Browse the repository at this point in the history

  3. update unit test description 

    setStateFromProps required valid props as parameter, otherwise it should not change state.
    Grace Guo committed May 25, 2017
    Configuration menu
    Copy the full SHA
    2644115 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2017

  1. fix per code review comments

    Grace Guo committed May 29, 2017
    Configuration menu
    Copy the full SHA
    bfe2497 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2017

  1. fix per code review comments

    Grace Guo committed May 30, 2017
    Configuration menu
    Copy the full SHA
    9483f36 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2017

  1. Merge branch 'master' into gg-VisualModalTests

    Grace Guo authored May 31, 2017
    Configuration menu
    Copy the full SHA
    e7ddd93 View commit details
    Browse the repository at this point in the history