chore: enable ruff's isort equivalent #28267
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Recently when I set up
ruff
(new linter/formatter that replaces black, isort, pyupgrade, ...) I didn't check that isort rules were enabled properly, this PR:ruff check --fix
with these new settings - everything here except a single change was auto-fixed in millisecondsFor the record, my configuration is based on the one suggested here -> astral-sh/ruff#4670 (comment)
For convenience, the list of all possible isort-related configs: https://docs.astral.sh/ruff/settings/#lint_isort_lines-after-imports.
Note that now that this is so fast and
--fix
works very well, it'd be easy to reconsider some configs if we wanted, for example settinglines-after-imports = 2
instead of-1
could be nice.