fix: Contribution percentages for ECharts plugins

[michael-s-molina]

SUMMARY

Fix percentages shown in tooltips of ECharts plugins that contain time offsets and contribution mode enabled. The ECharts version does not distinguish series and time shifts when calculating the contribution percentages as the legacy version does. Instead of showing something like series A 50%, series B 50%, series A (a year ago) 50%, series B (a year ago) 50%, it shows all series with 25%. With this fix, the contribution of time shifts are calculated independently.

This is another pre-requisite to unblock timeseries chart migrations.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Check that time shift contributions are calculated independently.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 13.51351% with 32 lines in your changes are missing coverage. Please review.

Project coverage is 67.30%. Comparing base (2e5f3ed) to head (e37fcf7).
Report is 44 commits behind head on master.

Files	Patch %	Lines
...perset/utils/pandas_postprocessing/contribution.py	11.42%	31 Missing ⚠️
.../plugin-chart-echarts/src/Timeseries/buildQuery.ts	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #28368      +/-   ##
==========================================
+ Coverage   60.49%   67.30%   +6.80%     
==========================================
  Files        1931     1934       +3     
  Lines       76241    76787     +546     
  Branches     8566     8572       +6     
==========================================
+ Hits        46122    51679    +5557     
+ Misses      28015    23011    -5004     
+ Partials     2104     2097       -7     

Flag	Coverage Δ
hive	?
javascript	57.71% <50.00%> (-0.02%)	⬇️
mysql	77.20% <11.42%> (?)
postgres	77.31% <11.42%> (?)
presto	?
python	77.50% <11.42%> (+14.01%)	⬆️
sqlite	76.76% <11.42%> (?)
unit	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[michael-s-molina]

@dosubot dosubot bot added the lgtm label 18 hours ago

@rusackas Does the bot add this label because someone approved the PR or because it reviewed the changes and considered them good enough to merge?

[rusackas]

@dosubot dosubot bot added the lgtm label 18 hours ago

@rusackas Does the bot add this label because someone approved the PR or because it reviewed the changes and considered them good enough to merge?

Because it was reviewed by a committer and is basically mergeable... we can turn it off if we'd like, I'm not sure it's helping much.

[michael-s-molina]

Because it was reviewed by a committer and is basically mergeable... we can turn it off if we'd like, I'm not sure it's helping much.

Got it. I believe we can turn it off as it's not providing additional value.

[rusackas]

Ok, it's off now :)