Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tests on database, dataset, saved_queries apis #28397

Merged
merged 4 commits into from
May 9, 2024

Conversation

dpgaspar
Copy link
Member

@dpgaspar dpgaspar commented May 9, 2024

SUMMARY

Fixes a couple of tests that are currently failing on master

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@pull-request-size pull-request-size bot added size/S and removed size/XS labels May 9, 2024
@dpgaspar dpgaspar changed the title fix: tests on database api fix: tests on database, dataset apis May 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.24%. Comparing base (2e5f3ed) to head (3d71875).
Report is 57 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #28397       +/-   ##
===========================================
+ Coverage   60.49%   83.24%   +22.74%     
===========================================
  Files        1931      521     -1410     
  Lines       76241    37255    -38986     
  Branches     8566        0     -8566     
===========================================
- Hits        46122    31012    -15110     
+ Misses      28015     6243    -21772     
+ Partials     2104        0     -2104     
Flag Coverage Δ
hive 49.08% <ø> (-0.09%) ⬇️
javascript ?
mysql 77.22% <ø> (?)
postgres 77.32% <ø> (?)
presto 53.66% <ø> (-0.14%) ⬇️
python 83.24% <ø> (+19.75%) ⬆️
sqlite 76.78% <ø> (?)
unit 58.35% <ø> (+0.72%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 9, 2024
@dpgaspar dpgaspar changed the title fix: tests on database, dataset apis fix: tests on database, dataset, saved_queries apis May 9, 2024
@dpgaspar dpgaspar merged commit 9c06595 into apache:master May 9, 2024
30 of 31 checks passed
@dpgaspar dpgaspar deleted the fix/tests branch May 9, 2024 12:43
imancrsrk pushed a commit to imancrsrk/superset that referenced this pull request May 10, 2024
jzhao62 pushed a commit to jzhao62/superset that referenced this pull request May 16, 2024
EnxDev pushed a commit to EnxDev/superset that referenced this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants