fix: run some CI tests against previous python version #28419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As currently python3.10 is our main version, we do run a bit of CI (not the full matrix) against 3.11. This is introducing doing the same for 3.9 as we do for 3.11. Check isn't required, but should show as failed and inform something broke 3.9 support
mistercrunch
requested review from
villebro,
geido,
eschutho,
rusackas,
betodealmeida,
nytai,
craig-rueda,
john-bodley,
kgabryje and
dpgaspar
as code owners
9 tasks
github-actions
bot
added
github_actions
|
Validated it installed python3.9 and ran integration tests here -> https://github.com/apache/superset/actions/runs/9026120305/job/24802927512?pr=28419#step:5:49 |
michael-s-molina
approved these changes
May 10, 2024
|
Thank you! ❤️ |
john-bodley
reviewed
May 10, 2024
| @@ -29,6 +29,8 @@ runs: | |||
| echo "PYTHON_VERSION=3.10" >> $GITHUB_ENV | |||
| elif [ "${{ inputs.python-version }}" = "next" ]; then | |||
| echo "PYTHON_VERSION=3.11" >> $GITHUB_ENV | |||
| elif [ "${{ inputs.python-version }}" = "previous" ]; then | |||
There was a problem hiding this comment.
@mistercrunch I wonder if previous, current, and next are somewhat abstract, i.e., what does "previous" actually mean? Would it be simpler to just use the version name?
dpgaspar
approved these changes
May 10, 2024
aehanno
pushed a commit
to kosmos-education/superset
that referenced
this pull request
May 13, 2024
jzhao62
pushed a commit
to jzhao62/superset
that referenced
this pull request
May 16, 2024
EnxDev
pushed a commit
to EnxDev/superset
that referenced
this pull request
May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As currently python3.10 is our main version, we do run a bit of CI (not
the full matrix) against 3.11.
This is introducing doing the same for 3.9 as we do for 3.11. Check
isn't required, but should show as failed and inform something broke 3.9
support
Now that refactor/cleaned up some of the CI / GHAs, it's pretty easy to get this going.