Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(permalink): adding anchor to dashboard permalink generation #28744

Merged
merged 6 commits into from
Jun 17, 2024
Merged

fix(permalink): adding anchor to dashboard permalink generation #28744

merged 6 commits into from
Jun 17, 2024

Conversation

fisjac
Copy link
Contributor

@fisjac fisjac commented May 28, 2024 •
edited by michael-s-molina
Loading

SUMMARY

This PR connects the state of the shareMenu the slice of state state.dashboardState.directPathToChild in order to access the last clicked tab within a dashboard. The id of the last child in the path is passed as the anchor for the permalink to ensure proper loading of the activeTab state.

Fixes #28741

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
https://www.loom.com/share/60d642624a2b4f039572610723781987

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue: New permalinks retain previous permalink activeTab state #28741
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added the dashboard Namespace | Anything related to the Dashboard label May 28, 2024
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jun 3, 2024
@geido geido requested a review from kgabryje June 10, 2024 16:18
@geido geido merged commit 914ebd9 into apache:master Jun 17, 2024
34 checks passed
@michael-s-molina michael-s-molina added the v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch label Jun 18, 2024
michael-s-molina pushed a commit that referenced this pull request Jun 26, 2024
@fisjac @michael-s-molina
fix(permalink): adding anchor to dashboard permalink generation (#28744)
a7b7b7d
@mistercrunch mistercrunch added 🍒 4.0.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Jul 24, 2024
eschutho pushed a commit that referenced this pull request Jul 24, 2024
@fisjac @eschutho
fix(permalink): adding anchor to dashboard permalink generation (#28744)
ae02302
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geido geido geido approved these changes

@eschutho eschutho Awaiting requested review from eschutho

@kgabryje kgabryje Awaiting requested review from kgabryje

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dashboard Namespace | Anything related to the Dashboard size/M v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch 🍒 4.0.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New permalinks retain previous permalink activeTab state
4 participants
@fisjac @geido @mistercrunch @michael-s-molina