Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Mixed Chart Filter Control): Allow delete condition for adhoc_filters_b #28771

Merged

Conversation

rtexelm
Copy link
Member

@rtexelm rtexelm commented May 29, 2024

SUMMARY

This is meant to fix a bug that would prevent the deletion of filters from Query B in the control panel of a mixed chart.
The condition to run the canDelete function for a filter previously only allowed for adhoc_filters as a valid value but the mixed chart uses adhoc_filters_b for the Query B group. This change should allow any string starting with adhoc_filters to be checked for deletion conditions.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

B:
filters_old-ezgif com-optimize
A:
filters_new-ezgif com-optimize

TESTING INSTRUCTIONS

  1. Create a Mixed Chart
  2. Add a filter to Query B
  3. Delete filter
  4. Delete last remaining temporal filter to test warning if is displayed

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@dosubot dosubot bot added change:frontend Requires changing the frontend explore:filter Related to filters in Explore labels May 29, 2024
@rtexelm rtexelm force-pushed the fix/unable-to-remove-filter-from-query/sc-80397 branch from 34d04b8 to 2633ad6 Compare May 29, 2024 23:21
@eschutho
Copy link
Member

@rtexelm can you add a small test for this, too? Thanks!

@eschutho eschutho merged commit 35e1820 into apache:master May 31, 2024
29 of 31 checks passed
@michael-s-molina michael-s-molina added the v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch label Jun 4, 2024
michael-s-molina pushed a commit that referenced this pull request Jun 5, 2024
eschutho pushed a commit that referenced this pull request Jun 23, 2024
@mistercrunch mistercrunch added 🍒 4.0.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels change:frontend Requires changing the frontend explore:filter Related to filters in Explore size/XS v4.0 Label added by the release manager to track PRs to be included in the 4.0 branch 🍒 4.0.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants