fix(Mixed Chart Filter Control): Allow delete condition for adhoc_filters_b
#28771
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This is meant to fix a bug that would prevent the deletion of filters from
Query B
in the control panel of a mixed chart.The condition to run the
canDelete
function for a filter previously only allowed foradhoc_filters
as a valid value but the mixed chart usesadhoc_filters_b
for theQuery B
group. This change should allow any string starting withadhoc_filters
to be checked for deletion conditions.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
B:
A:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION