Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use upload v2 for slack #28783

Merged
merged 1 commit into from
May 30, 2024
Merged

fix: use upload v2 for slack #28783

merged 1 commit into from
May 30, 2024

Conversation

eschutho
Copy link
Member

SUMMARY

After #28423 I found one more place where we are still calling the old slack api method.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@eschutho eschutho marked this pull request as ready for review May 30, 2024 18:43
@eschutho eschutho force-pushed the elizabeth/bump-slack-upload branch from 07e98a7 to c2bf908 Compare May 30, 2024 20:25
sadpandajoe
sadpandajoe approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@sadpandajoe sadpandajoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eschutho eschutho merged commit a608bdb into master May 30, 2024
30 checks passed
EnxDev pushed a commit to EnxDev/superset that referenced this pull request May 31, 2024
@eschutho @EnxDev
fix: use upload v2 for slack (apache#28783)
f478fa6
@eschutho eschutho mentioned this pull request Jun 1, 2024
Merged
9 tasks
@rusackas rusackas deleted the elizabeth/bump-slack-upload branch June 4, 2024 16:49
eschutho added a commit that referenced this pull request Jun 5, 2024
@eschutho @sadpandajoe
fix: use upload v2 for slack (#28783)
5072c79 
(cherry picked from commit a608bdb)
@sadpandajoe sadpandajoe mentioned this pull request Sep 30, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@betodealmeida betodealmeida betodealmeida approved these changes

@sadpandajoe sadpandajoe sadpandajoe approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eschutho @betodealmeida @sadpandajoe