Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix local state 'columns' #2896

Merged

Commits on Jun 3, 2017

  1. fix local state 'columns'

    I found a bug in VisualizeModal:
    in setStateFromProps(props), we create columns object and set into state.
    But setStateFromProps will be called every componentWillReceiveProps, which means when user close Modal, open Modal etc, it will reset columns state to original props. As a result if user changed any checkbox, then close and re-open modal, his previous change will lost. This thing will become more annoying when mixed with redux updating its state.
    
    I think we should keep 'columns' as a local state, and it should remember states even after user close Modal and reopen it. my fix is just calling setStateFromProps from constructor, not from every componentWillReceiveProps.
    Grace Guo committed Jun 3, 2017
    Configuration menu
    Copy the full SHA
    55e01cf View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2017

  1. fix method name per code review

    Grace Guo committed Jun 15, 2017
    Configuration menu
    Copy the full SHA
    27870d3 View commit details
    Browse the repository at this point in the history
  2. Merge branch 'master' into gg-keepColumnsStateLocal

    Grace Guo authored Jun 15, 2017
    Configuration menu
    Copy the full SHA
    c5a2107 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'master' into gg-keepColumnsStateLocal

    Grace Guo authored Jun 15, 2017
    Configuration menu
    Copy the full SHA
    bcea614 View commit details
    Browse the repository at this point in the history