fix: Remove BASE_AXIS from pre-query #29084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #29084 +/- ##
===========================================
+ Coverage 60.48% 83.66% +23.17%
===========================================
Files 1931 518 -1413
Lines 76236 37468 -38768
Branches 8568 0 -8568
===========================================
- Hits 46114 31348 -14766
+ Misses 28017 6120 -21897
+ Partials 2105 0 -2105
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
john-bodley
commented
Jun 5, 2024
|
|
||
|
|
||
| def get_xaxis_label(columns: list[Column] | None) -> str | None: | ||
| def get_x_axis_label(columns: list[Column] | None) -> str | None: |
There was a problem hiding this comment.
Renaming for consistency.
| def get_base_axis_labels(columns: list[Column] | None) -> tuple[str, ...]: | ||
| axis_cols = [ |
There was a problem hiding this comment.
Refactoring using shared logic.
michael-s-molina
approved these changes
Jun 5, 2024
michael-s-molina
added
the
v4.0
michael-s-molina
pushed a commit
that referenced
this pull request
Jun 5, 2024
(cherry picked from commit 17d7e7e)
michael-s-molina
pushed a commit
that referenced
this pull request
Jun 5, 2024
(cherry picked from commit 17d7e7e)
michael-s-molina
pushed a commit
that referenced
this pull request
Jun 5, 2024
(cherry picked from commit 17d7e7e)
mistercrunch
pushed a commit
to preset-io/superset
that referenced
this pull request
Jun 28, 2024
(cherry picked from commit 17d7e7e)
mistercrunch
added
🍒 4.0.2
🏷️ bot
eschutho
pushed a commit
that referenced
this pull request
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR fixes a regression introduced in #21163 where—if enabled—the generic x-axis is incorrectly included in the pre-query (for engines which don’t support JOINs or subqueries) when determining the top-n series.
Specifically, the top-n series are determined for the entire period, i.e., sans the x-axis as a dimension, however within the confines of the generic x-axis said axis is included as a column. This resulted in an explosion of records—via (x, y) pairs—meaning the top-n typically would just be the top-1. The fix is merely to exclude said column when determining the top-n series.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
CI and tested locally. Sadly writing unit/integration tests for said logic is non-trivial given i) the scale of the
get_sqla_queryfunction (which is ~ 700 lines of code), and ii) the lack of associated tests.ADDITIONAL INFORMATION