chore: enable ruff lint rule TRY201 and B904 to improve raise stack traces
#29166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
risk:db-migration
When intercepting and re-raising an error in python, it's almost always better to simply `raise` over raising the exception alias ie: `raise ex`. The main reason is that the stack trace often (always?) gets truncated in the process, losing track of where the error occurred. Similarly, when intercepting and re-raising another exception, it's better to `raise AnotherException() from ex`, so I'm fixing and enforcing this as well. I found this while debugging and dealing with incomplete stack traces, and thought it be a good idea to fix and enforce using ruff's TRY201 and B904
mistercrunch
changed the title
raise stack traces
|
Summoning some of our backend / python folks - @betodealmeida @dpgaspar @john-bodley , what do you think? |
giftig
approved these changes
Jun 12, 2024
|
I think there might be cases where you legitimately don't want to use |
john-bodley
approved these changes
Jun 12, 2024
yeah I didn't know that until I was like "where's the rest of my stacktrace!?!?! how did we get here?" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When intercepting and re-raising an error in python, it's almost always better to simply
raiseover raising the exception alias ie:raise ex. The main reason is that the stack trace often (always?) gets truncated in the process, losing track of where the error occurred.Similarly, when intercepting and re-raising another exception, it's better to
raise AnotherException() from ex(usingfrom), so I'm fixing and enforcing this as well.I found this while debugging and dealing with incomplete stack traces, and thought it be a good idea to fix and enforce using ruff's TRY201 and B904