refactor(sqllab): nonblocking delete query editor #29233
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Following up #24539
This commit modifies the
removeQueryEditor
function to asynchronously handle the process of deleting a queryEditor in localStorage in the same way as in non-persistent mode and periodically post deleted items to persistence via AutoSync'sdeleteSqlEditor
.This commit made the following changes:
destroyedQueryEditors
)removeQueryEditor
has been modified to always update to localStorage in the same way as in non-persistence modedeleteSqlEditor
periodically and then remove the completed item fromdestroyedQueryEditors
on successdestroyedQueryEditors
for persistence modeBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
before--nonblocking-close.mov
After:
after--nonblocking-close.mp4
TESTING INSTRUCTIONS
set SQLLAB_BACKEND_PERSISTENCE on
go to sqllab and then close each tab quickly
ADDITIONAL INFORMATION