-
Notifications
You must be signed in to change notification settings - Fork 13.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adds the ECharts Sankey chart #29329
feat: Adds the ECharts Sankey chart #29329
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #29329 +/- ##
==========================================
+ Coverage 60.48% 70.32% +9.83%
==========================================
Files 1931 1961 +30
Lines 76236 78431 +2195
Branches 8568 8951 +383
==========================================
+ Hits 46114 55159 +9045
+ Misses 28017 21078 -6939
- Partials 2105 2194 +89
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
a1d6390
to
ccce46a
Compare
ccce46a
to
a69e9de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
/testenv up |
@villebro Ephemeral environment spinning up at http://35.161.245.38:8080. Credentials are |
|
||
def _pre_action(self) -> None: | ||
groupby = self.data.get("groupby") | ||
if groupby and len(groupby) > 1: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be:
if groupby and len(groupby) > 1: | |
if groupby and len(groupby) == 2: |
The answer seems to be no as the form-data could actually be corrupted with three or more groupings even though only the first two are used in legacy chart.
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
This PR creates the ECharts Sankey chart which visually tracks the movement and transformation of values across system stages. It also adds the chart migration logic (legacy ➡️ ECharts). Users can execute this migration using the CLI command and disable the legacy version with the VIZ_TYPE_DENYLIST configuration.
I added the minimum required controls to allow the migration but many more controls can be added in the future to improve the chart's customizability.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Check all features.
ADDITIONAL INFORMATION