Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): remove unused "type: ignore" comment to unblock precommit check in CI #29830

Merged
merged 1 commit into from
Aug 1, 2024

Conversation

hainenber
Copy link
Contributor

@hainenber hainenber commented Aug 1, 2024

fix(ci): remove unused "type: ignore" comment to unblock precommit check in CI

SUMMARY

Fix blocking CI in feature branches, for example:
image

Link: https://github.com/apache/superset/actions/runs/10200377636/job/28219694742

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

At least pre-commit checks CI step should pass green

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

…eck in CI

Signed-off-by: hainenber <dotronghai96@gmail.com>
@hainenber hainenber marked this pull request as ready for review August 1, 2024 15:02
@hainenber
Copy link
Contributor Author

The pre-commit checks CI step is green now. PR is ready for review! :D

https://github.com/apache/superset/actions/runs/10200704000/job/28220850318?pr=29830

Copy link

codecov bot commented Aug 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.70%. Comparing base (76d897e) to head (f015558).
Report is 1094 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #29830       +/-   ##
===========================================
+ Coverage   60.48%   83.70%   +23.22%     
===========================================
  Files        1931      527     -1404     
  Lines       76236    38011    -38225     
  Branches     8568        0     -8568     
===========================================
- Hits        46114    31819    -14295     
+ Misses      28017     6192    -21825     
+ Partials     2105        0     -2105     
Flag Coverage Δ
hive 49.04% <0.00%> (-0.12%) ⬇️
javascript ?
mysql 76.80% <0.00%> (?)
postgres 76.89% <0.00%> (?)
presto 53.59% <0.00%> (-0.21%) ⬇️
python 83.70% <100.00%> (+20.22%) ⬆️
sqlite 76.38% <0.00%> (?)
unit 59.95% <100.00%> (+2.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rusackas
Copy link
Member

rusackas commented Aug 1, 2024

Thanks!

@rusackas rusackas merged commit 71786db into apache:master Aug 1, 2024
52 of 65 checks passed
@hainenber hainenber deleted the fix-mypy-precommit-check-in-ci branch August 1, 2024 15:53
WanjohiWanjohi pushed a commit to IDinsight/surveystream_superset_source that referenced this pull request Aug 6, 2024
…eck in CI (apache#29830)

Signed-off-by: hainenber <dotronghai96@gmail.com>
@sadpandajoe sadpandajoe added the v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch label Aug 21, 2024
sadpandajoe pushed a commit that referenced this pull request Aug 21, 2024
…eck in CI (#29830)

Signed-off-by: hainenber <dotronghai96@gmail.com>
(cherry picked from commit 71786db)
@github-actions github-actions bot added 🍒 4.1.0 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels labels Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS v4.1 Label added by the release manager to track PRs to be included in the 4.1 branch 🍒 4.1.0 🍒 4.1.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants