-
Notifications
You must be signed in to change notification settings - Fork 14k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(explore): Add time shift color control to ECharts #29897
feat(explore): Add time shift color control to ECharts #29897
Conversation
/testenv up |
@yousoph Ephemeral environment spinning up at http://35.90.51.45:8080. Credentials are |
The only concern that I have with this approach is about charts consumption at the dashboard layer. It might be confusing for users that time shifts are represented differently among charts which might harm UX. I'm not sure if we should discuss more about this as you can see in #26041 |
Another option is to assume that all time shifts will be of varied colors and remove the need for this checkbox. Essentially, not make the correlation between series and their time shifts using colors, only the legend. |
I'm not too concerned about the dashboard level - I'm guessing that there will be consistency at the org or creator level with this control based on preference so there aren't likely to be too many discrepancies at the dashboard level. In terms of defaulting to use varied colors, I'm not opposed to that but I thought the original fix in #24048 was to retain the same color for the time shift as the original control. Since that was the fix that was implemented, we thought adding a control would be the best way to give the flexibility to use either option. |
This is a good point @yousoph. We have other controls that might provoke the same effect if not used consistently. Thank you for the additional context 👍🏼 |
Hello, any news about this feature? It's really important for us. Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks!
Ephemeral environment shutdown and build artifacts deleted. |
@fpassantino sorry for the delay. |
SUMMARY
Adds a new checkbox control to timeseries capable charts allowing the user to choose whether or not to duplicate the original series colors for the shifts.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
new-time-shift-color.mov
TESTING INSTRUCTIONS
COUNT(*)
as your metric.order_date
as the X-Axis and a Month time grain.CREATE CHART
.Customize
tabTime Shift color
checkboxADDITIONAL INFORMATION